Fix DO_UCALL may_be_trampoline flag to match DO_FCALL#21695
Closed
andypost wants to merge 1 commit intophp:masterfrom
Closed
Fix DO_UCALL may_be_trampoline flag to match DO_FCALL#21695andypost wants to merge 1 commit intophp:masterfrom
andypost wants to merge 1 commit intophp:masterfrom
Conversation
The ZEND_DO_UCALL handler hardcodes may_be_trampoline=0 when calling i_init_func_execute_data(), while ZEND_DO_FCALL passes 1. When the optimizer converts DO_FCALL to DO_UCALL for user functions that return by reference, the ASSIGN_REF opcode receives an incorrectly initialized return value, producing "Invalid opcode" errors or segfaults. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ZEND_DO_UCALL handler hardcodes may_be_trampoline=0 when calling i_init_func_execute_data(), while ZEND_DO_FCALL passes 1. When the optimizer converts DO_FCALL to DO_UCALL for user functions that return by reference, the ASSIGN_REF opcode receives an incorrectly initialized return value, producing "Invalid opcode" errors or segfaults.
Closes #21691